Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Connector-V2] Fix connector support SPI but without no args constructor #6551

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR remove SPI on SeaTunnelSource/SeaTunnelSink class when it had TableSourceFactory/TableSinkFactory. Also do some check for SPI on SeaTunnelSource/SeaTunnelSink.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X requested a review from hailin0 March 20, 2024 12:23
@@ -15,7 +15,7 @@
* limitations under the License.
*/

package org.apache.seatunnel.connectors.seatunnel.file.oss.config;
package org.apache.seatunnel.connectors.seatunnel.file.oss.jindo.config;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change jindo oss file path. Because it conflicted with oss connector.

@EricJoy2048 EricJoy2048 merged commit 5f3c9c3 into apache:dev Mar 21, 2024
4 checks passed
@Hisoka-X Hisoka-X deleted the fix-spi-constructor branch March 21, 2024 06:28
LeonYoah added a commit to LeonYoah/seatunnel that referenced this pull request Mar 22, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants